Make warnings fail the build #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some unused code that was generating warnings.
Since these are all used for place-holders for things that the compiler renders impossible, we should use `panic` instead.
Means we're not special-casing `Type` import.
We have two things called `Type`: the AST-level type and the Schema-level type. Here, we rename both. `GType` is chosen for consistency with `GInt`, `GBool`, etc. Motivation is allowing us to work on GHC 8.0 and 8.2. See protolude/protolude#79 for details.
Merged
teh
approved these changes
Feb 5, 2018
Collaborator
teh
left a comment
teh
left a comment
There was a problem hiding this comment.
Thanks! The only mildly controversial chance could be Type -> GType but it's in an internal module so people have been warned :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by a discussion on #154. Commit history pretty much outlines what's changed.